Skip to content

Make AgentPool updates cause replacement#3655

Merged
danielrbradley merged 1 commit into
masterfrom
containerservice-agentpool-forcenew
Oct 18, 2024
Merged

Make AgentPool updates cause replacement#3655
danielrbradley merged 1 commit into
masterfrom
containerservice-agentpool-forcenew

Conversation

@danielrbradley

Copy link
Copy Markdown
Contributor

As noted on https://learn.microsoft.com/en-us/azure/aks/gpu-multi-instance?tabs=azure-cli#gpu-instance-profiles

You can't change the applied GPU instance profile after node pool creation.

As noted on https://learn.microsoft.com/en-us/azure/aks/manage-node-pools#limitations

You can't change the VM size of a node pool after you create it.

Fixes #2462

As noted on https://learn.microsoft.com/en-us/azure/aks/gpu-multi-instance?tabs=azure-cli#gpu-instance-profiles

> You can't change the applied GPU instance profile after node pool creation.

As noted on https://learn.microsoft.com/en-us/azure/aks/manage-node-pools#limitations

> You can't change the VM size of a node pool after you create it.

Fixes #2462
@danielrbradley danielrbradley requested review from a team and thomas11 October 18, 2024 15:22
@danielrbradley danielrbradley self-assigned this Oct 18, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@codecov

codecov Bot commented Oct 18, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.82%. Comparing base (d32b4b6) to head (1bc8c23).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3655   +/-   ##
=======================================
  Coverage   59.82%   59.82%           
=======================================
  Files          67       67           
  Lines       10667    10667           
=======================================
  Hits         6381     6381           
  Misses       3794     3794           
  Partials      492      492           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley danielrbradley enabled auto-merge (squash) October 18, 2024 15:38
@danielrbradley danielrbradley merged commit 08b61fe into master Oct 18, 2024
@danielrbradley danielrbradley deleted the containerservice-agentpool-forcenew branch October 18, 2024 15:59
@pulumi-bot

Copy link
Copy Markdown
Contributor

This PR has been shipped in release v2.68.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to set property to null on AgentPool

3 participants